Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemVerilog: concurrent assertion items go into module namespace #575

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

kroening
Copy link
Member

Concurrent assertion items (assert/assume/cover) that are module items with a block label go into the module name space, not into a separate "property" name space.

Assertion items without block item now get a label based on the kind of the assertion item (assert/assume/cover).

@kroening kroening marked this pull request as ready for review June 23, 2024 18:22
@tautschnig
Copy link
Collaborator

Concurrent assertion items (assert/assume/cover) that are module items with a block label go into the module name space, not into a separate "property" name space.

Assertion items without block item now get a label based on the kind of the assertion item (assert/assume/cover).

I can see that the commit does what the above message says, but why is this the right thing to do?

@kroening
Copy link
Member Author

I can see that the commit does what the above message says, but why is this the right thing to do?

One argument in favour is that it appears to be what other tools are doing (e.g., XCelium uses the same scheme for assertions with label, and __assert_.number for assertions without).

@kroening
Copy link
Member Author

I of course wish that the IEEE standard be clear about it, but couldn't find anything.

@kroening kroening force-pushed the assertion-item-namespace branch from eb6ba55 to 8379b59 Compare June 24, 2024 15:55
Concurrent assertion items (assert/assume/cover) that are module items with
a block label go into the module name space, not into a separate "property"
name space.

Assertion items without block item now get a label based on the kind of the
assertion item (assert/assume/cover).
@kroening kroening force-pushed the assertion-item-namespace branch from 8379b59 to 5cca195 Compare June 24, 2024 16:54
@tautschnig tautschnig merged commit 668be19 into main Jun 25, 2024
6 checks passed
@tautschnig tautschnig deleted the assertion-item-namespace branch June 25, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants